Skip to content

Add history entry for SecOC longitudinal control merge to upstream comma openpilot#59

Merged
nelsonjchen merged 3 commits intomainfrom
copilot/fix-03224100-dda4-4fa9-a9e3-e03ecd3b1abf
Sep 29, 2025
Merged

Add history entry for SecOC longitudinal control merge to upstream comma openpilot#59
nelsonjchen merged 3 commits intomainfrom
copilot/fix-03224100-dda4-4fa9-a9e3-e03ecd3b1abf

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Sep 29, 2025

  • Analyzed the repository structure and current timeline format
  • Retrieved PR #1385 information from commaai/opendbc
  • Identified the correct location in September 2025 section for the new entry
  • Add history entry for SecOC longitudinal control merge to upstream comma openpilot
  • Verify the change follows the existing documentation format
  • Fix SecOC casing to match proper spelling used throughout document

Added a history entry documenting the merge of SecOC longitudinal control support into upstream comma openpilot/opendbc (PR #1385 by chrispypatt). The entry is placed in the September 2025 section and follows the existing documentation format with a link to the PR and descriptive sub-bullet. Fixed casing from "SECOC" to "SecOC" to match the proper spelling used consistently throughout the document.

Original prompt

This section details on the original issue you should resolve

<issue_title>SecOC longitudinal has been merged to upstream comma openpilot.</issue_title>
<issue_description>commaai/opendbc#1385

Please add a history entry to the doc for this. </issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes #58

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

…mma openpilot

Co-authored-by: nelsonjchen <5363+nelsonjchen@users.noreply.github.com>
Copilot AI changed the title [WIP] SecOC longitudinal has been merged to upstream comma openpilot. Add history entry for SecOC longitudinal control merge to upstream comma openpilot Sep 29, 2025
Copilot AI requested a review from nelsonjchen September 29, 2025 18:47
README.md Outdated
* [An attempt is made by tsuk1247 to dump the key on a 2025 Vellfire (TSS3) but it can't communicate/won't work.](https://discord.com/channels/469524606043160576/905950538816978974/1414826230712238231)
* ["do we have any devlopments on the tundra EPS "? Willem: "No updates 🙁"](https://discord.com/channels/469524606043160576/905950538816978974/1417100272496283830)
* [SecOC longitudinal control support has been merged into upstream comma openpilot/opendbc.](https://github.com/commaai/opendbc/pull/1385)
* Pull request by chrispypatt adds SECOC longitudinal control functionality to Toyota vehicles with TSK/SecOC security.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use SecOC as the proper case spelling

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit 8dcd663. Changed "SECOC" to "SecOC" to match the proper casing used consistently throughout the document.

@calvinpark
Copy link
Copy Markdown
Collaborator

Oh wtf, copilot opened this PR??

@nelsonjchen
Copy link
Copy Markdown
Member

Yeah, make an issue and it'll open one of assigned it

@nelsonjchen
Copy link
Copy Markdown
Member

@copilot fix that casing issue to SecOC.

Co-authored-by: nelsonjchen <5363+nelsonjchen@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Sep 29, 2025

@copilot fix that casing issue to SecOC.

Fixed in commit 8dcd663. Changed "SECOC" to "SecOC" to match the proper casing used throughout the document.

@nelsonjchen nelsonjchen marked this pull request as ready for review September 29, 2025 19:03
@nelsonjchen nelsonjchen merged commit 6d74cd2 into main Sep 29, 2025
Copilot AI requested a review from nelsonjchen September 29, 2025 19:03
@nelsonjchen nelsonjchen deleted the copilot/fix-03224100-dda4-4fa9-a9e3-e03ecd3b1abf branch September 29, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SecOC longitudinal has been merged to upstream comma openpilot.

3 participants