Added changes for enabling osmh. #316
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
| @@ -0,0 +1,11 @@ | |||
| data "oci_identity_tenancy" "test_tenancy" { | |||
There was a problem hiding this comment.
why is this named "test_tenancy"? We should give it a different name. I suspect this was lifted directly from OCI sample code where everything is "test_something".
There was a problem hiding this comment.
You renamed this to "tenancy_ocid". That really isn't what this is. Sure, we're only getting the tenancy so we can get its ocid, but what is actually returned is the full tenancy info. Maybe rename to "current_tenancy" or "user_tenancy"?
|
I'm not seeing a way to specify an existing profile, but maybe I'm missing that. I saw from your slack message that you don't think this should be available in the UI (to be discussed), but why not in the terraform? |
terraform/modules/policies/locals.tf
Outdated
| plugin_policy_statement2 = "Allow dynamic-group ${oci_identity_dynamic_group.wlsc_instance_principal_group.name} to use wlms-managed-instance-plugins in tenancy" | ||
| plugin_policy_statement = compact([local.plugin_policy_statement1, local.plugin_policy_statement2]) | ||
|
|
||
| #Policies required for enabling the osmh plugin |
There was a problem hiding this comment.
I don't see a corresponding orahub MR. Is this all going to be done through terraform? If so then we don't need dynamic group policies. If there is going to be an image change to scripts for the enabling please explain in that MR why we need these policies. These are very powerful root privileges.
There was a problem hiding this comment.
Can you provide in https://confluence.oraclecorp.com/confluence/display/JCSWLS/OMH+Integration+Functional+and+Technical+Design why each policy is needed?
…efore profile creation to avoid failure scenarios
There was a problem hiding this comment.
Approved, but I'd really like comment #316 (comment) addressed. tenancy_ocid is just not a good name. I can live with it, but it doesn't really reflect what resource is being returned; the resource is a tenancy but we just happen to use this to get the tenancy ocid.
| "ol8_mysql80_tools_community-x86_64", | ||
| "ol8_uekr7-x86_64", | ||
| "ol8_mysql80_community-x86_64" | ||
| ] |
There was a problem hiding this comment.
Do we really want to provide mysql packages from OSMH OOB? WLS for OCI recommends using Oracle database in general. This is more a PM question if we want to provides updates to mysql by default.
5 participants
No description provided.