Added changes for enhancement in OSMH policies. #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
telake
reviewed
May 16, 2025
ManviGupta-prog
commented
May 20, 2025
There was a problem hiding this comment.
I had to change the version of Terraform to the latest one to support the data source for OSMH. If anyone is reviewing this, please let me know if this is feasible.
There was a problem hiding this comment.
I'm confused. Where is a data source used in the changes? I don't see it.
|
Can you please add to the description what testing you did? In https://jira.oraclecorp.com/jira/browse/JCS-14845 I only highlighted the 2 known problems if someone tried to run our default code without changes. Did you have to set any other tf variables to provision with new profile (the default)? |
telake
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with the following scenarios:
Terraform CLI changes.
If a stack is created through the Terraform CLI with the default values, OSMH will be enabled by default, since select existing profile defaults to false, a new profile will be created.
If one needs to select an Existing profile, set the value to true & provide the profile OCID. If the OCID is not provided validation error will be thrown.