fix: LOB failures during OnConflict merges #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One-to-one or one-to-many relationships which have LOB types in the child table fail when the size of the LOB exceeds 32767 characters (the max length for VARCHAR2). The merge statement assigns a bind variable which is typed as just a string or []byte. The fix converts the string or []byte bind variable to a godror.Lob object when its size exceeds MaxInt16.
Type of change
How Has This Been Tested?
I have added two new tests which produce this behavior and validate the fixes. You can uncomment the fixes in common.go to see the original failure.
Checklist: