Skip to content

Correctly handle nil pointer values for nullable columns #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
Merged

Correctly handle nil pointer values for nullable columns #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bec73c
correctly handle nil pointer values for nullable columns
aarrasseayoub01 Nov 6, 2025
6db4177
Unskipping TestBooleanNullableColumn test
aarrasseayoub01 Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions oracle/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,10 @@ func convertValue(val interface{}) interface{} {

// Dereference pointers
rv := reflect.ValueOf(val)
if rv.Kind() == reflect.Ptr && rv.IsNil() {
return nil
}

for rv.Kind() == reflect.Ptr && !rv.IsNil() {
rv = rv.Elem()
val = rv.Interface()
Expand Down
3 changes: 1 addition & 2 deletions tests/boolean_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,9 +259,8 @@ func TestBooleanStringCoercion(t *testing.T) {
}
}


func TestBooleanNullableColumn(t *testing.T) {
t.Skip("Skipping until nullable bool bug is resolved")
// t.Skip("Skipping until nullable bool bug is resolved")
DB.Migrator().DropTable(&BooleanTest{})
DB.AutoMigrate(&BooleanTest{})

Expand Down
Loading