docs(workbench): rewrite welcome.md to match #161 reality (one click, not auto-open)#162
Open
fede-kamel wants to merge 1 commit into
Open
docs(workbench): rewrite welcome.md to match #161 reality (one click, not auto-open)#162fede-kamel wants to merge 1 commit into
fede-kamel wants to merge 1 commit into
Conversation
… not auto-open) Signed-off-by: Federico Kamelhar <federico.kamelhar@oracle.com>
oracle-contributor-agreement
Bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After PR #161 moved the tier startup into postAttachCommand and deleted postStart.sh, welcome.md was left referencing the old setup ('Three tiers are auto-started by postStart.sh') — which now points to a deleted file. Plus the welcome was promising 'a separate browser tab is opening' which doesn't reliably happen.
Honest welcome.md
Now reads:
openPreview+code --open-url) but Codespaces VS Code Web doesn't reliably honor either from shell contextworkbench-attach.sh, notpostStart.sh)Why no auto-open
Five PRs tried (#155, #157, #158, #160, #161). Each fixed a real bug along the way (deps, lifecycle ordering, URI format) but the final mile — programmatically opening Simple Browser from a shell script in postAttachCommand — doesn't have a reliable mechanism in current Codespaces VS Code Web. The platform doesn't expose a guaranteed-to-fire path from shell. Document it honestly rather than pretending.
Related