Update variables and use Terraform registry in files. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yimw
commented
Nov 5, 2018
yimw
commented
- Update Terraform registry in files.
- Update hostname_label in oci_core_instance.
- Use list private_ips to handle private ip assign for multiple instances.
- Update display_name in oci_core_volume.
- Use list subnet_ocids for multiple instances creating on different subnets.
examples/instance_default/README.md
Outdated
| # Compute Instance Configurations | ||
| instance_display_name = "sample_instance" | ||
| source_ocid = "ocid1.image.oc1.phx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" | ||
| vcn_ocid = "ocid1.vcn.oc1.phx.xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx" |
Contributor
There was a problem hiding this comment.
vcn_ocid no longer used
README.md
Outdated
| instance_count | Number of instances to launch | ||
| block_storage_sizes_in_gbs | The size in GBs of block volumes created and attached to each instance | ||
| attachment_type | Attachment type (Note: paravirtualized attachment may not be supported by some instance images) | ||
| attachment_type | Support two types of volume attachments: iSCSI and Paravirtualized. |
Contributor
There was a problem hiding this comment.
The type of volume attachment. Allowed values are: iscsi, paravirtualized
README.md
Outdated
| private_ips | A list of private IP address of your choice to assign to the VNIC | ||
| skip_source_dest_check | Specifies whether the source/destination check is disabled on the VNIC | ||
| subnet_ocid | Unique identifier (OCID) of the subnet in which the VNIC is created | ||
| subnet_ocids | A list of of the subnet OCID in which the VNIC is created |
Contributor
There was a problem hiding this comment.
A list of of the subnet OCIDs in which to place the instance primary VNICs
| The [examples](https://github.com/oracle-terraform-modules/terraform-oci-compute-instance/tree/master/examples/instance_default) folder contains a detailed example that shows how to use this module. | ||
|
|
||
| The following code example creates an Oracle Cloud Infrastructure compute instance: | ||
|
|
Contributor
There was a problem hiding this comment.
There's a note further up in this readme that is no longer true - "The subnet, the compute instances, and the block volumes all must be in the same compartment, as specified by the compartment_ocid parameter." The subnet can now be in any compartment.
briangustafson
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.