-
Notifications
You must be signed in to change notification settings - Fork 59
Adds opctl environment validator decorator. #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrDzurb
merged 2 commits into
feature/forecasting
from
ODSC-47201/operator_environment_validator
Sep 21, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| #!/usr/bin/env python | ||
|
|
||
| # Copyright (c) 2023 Oracle and/or its affiliates. | ||
| # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/ | ||
|
|
||
| import pytest | ||
| from ads.opctl.decorator import common | ||
| from ads.opctl.decorator.common import validate_environment, OpctlEnvironmentError | ||
| from unittest.mock import patch | ||
|
|
||
|
|
||
| class TestOpctlDecorators: | ||
| """Tests the all OPCTL common decorators.""" | ||
|
|
||
| @patch("ads.opctl.decorator.common.NB_SESSION_OCID", None) | ||
| @patch("ads.opctl.decorator.common.JOB_RUN_OCID", None) | ||
| @patch("ads.opctl.decorator.common.PIPELINE_RUN_OCID", None) | ||
| @patch("ads.opctl.decorator.common.DATAFLOW_RUN_OCID", None) | ||
| @patch("ads.opctl.decorator.common.MD_OCID", None) | ||
| def test_validate_environment_success(self): | ||
| """Tests validating environment decorator.""" | ||
|
|
||
| @validate_environment | ||
| def mock_function(): | ||
| return "SUCCESS" | ||
|
|
||
| assert mock_function() == "SUCCESS" | ||
|
|
||
| @patch("ads.opctl.decorator.common.NB_SESSION_OCID", "TEST") | ||
| def test_validate_environment_fail(self): | ||
| """Tests validating environment decorator fails.""" | ||
|
|
||
| @validate_environment | ||
| def mock_function(): | ||
| return "SUCCESS" | ||
|
|
||
| with pytest.raises(OpctlEnvironmentError): | ||
| assert mock_function() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking only the environment variable might not cause problem if user set the value manually in a supported environment. I think, since the root cause of the operation not being supported is that the environment does not support certain dependency, for example, docker. Maybe it is enough to tell users that since docker is not installed, the operation is not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! User may not have set up dataflow, for example