Fix an adaptived bug where multiple rules weren't properly loaded #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
drakenclimber
requested review from
sidkumar99
and removed request for
sidkumar99
gkennedy12
reviewed
Jan 30, 2025
Contributor
|
LGTM. Just a question. |
drakenclimber
force-pushed
the
multiple_rules
branch
from
5c61e4e to
07b11d8
Compare
drakenclimber
force-pushed
the
multiple_rules
branch
from
07b11d8 to
0a552f6
Compare
Fix a bug where only up to two rules could be added. The linked list ->next pointer was being mismanaged when more than 2 rules were present in the JSON config file. Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> Reviewed-by: George Kennedy <george.kennedy@oracle.com> Acked-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Add a test to verify that multiple (more than 2) rules are properly added. $ ./test070 ./ Initializing cause always Initializing effect print Initializing cause always Initializing effect print Initializing cause always Initializing effect print Initializing cause always Initializing effect print Initializing cause always Initializing effect print Rule "1" loaded Rule "2" loaded Rule "3" loaded Rule "4" loaded Rule "5" loaded ... Cleaning up rule 3 Cleaning up cause always Cleaning up effect print Cleaning up rule 4 Cleaning up cause always Cleaning up effect print Cleaning up rule 5 Cleaning up cause always Cleaning up effect print Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> Reviewed-by: George Kennedy <george.kennedy@oracle.com> Acked-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com> Reviewed-by: George Kennedy <george.kennedy@oracle.com> Acked-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
drakenclimber
force-pushed
the
multiple_rules
branch
from
0a552f6 to
26e7c43
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where only up to two rules could be added. The linked list
->next pointer was being mismanaged when more than 2 rules were present
in the JSON config file.