Skip to content

Minor update to enable thread dumps lock by default #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Minor update to enable thread dumps lock by default #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c9c318
Minor update to enable thread dumps lock by default
Aug 27, 2024
9ef800b
Add -D option to disable padding on startup
Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/cluster_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ func startCluster(cmd *cobra.Command, connection ClusterConnection, serverCount,
func getCommonArguments(connection ClusterConnection) []string {
splitArguments := strings.Split(connection.Arguments, " ")
return append(splitArguments, "-cp", connection.BaseClasspath, getPersistenceProperty(connection.PersistenceMode),
getLogLevelProperty(logLevelParam))
getLogLevelProperty(logLevelParam), "-Dcom.oracle.coherence.common.util.Threads.dumpLocks=FULL")
}

func startClient(cmd *cobra.Command, connection ClusterConnection, class string) error {
Expand Down
6 changes: 6 additions & 0 deletions pkg/cmd/monitor_cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ var (
padMaxHeightParam = true
showAllPanels bool
ignoreRESTErrors bool
disablePadding bool
monitorCluster bool
additionalMonitorMsg = pressAdditional
expandedPanel = ""
Expand Down Expand Up @@ -161,6 +162,10 @@ Use --show-panels to show all available panels.`,
return err
}

if disablePadding {
padMaxHeightParam = false
}

// check for default layouts
if l, ok := defaultMap[layoutParam]; ok {
layoutParam = l
Expand Down Expand Up @@ -1338,6 +1343,7 @@ func init() {
monitorClusterCmd.Flags().StringVarP(&layoutParam, "layout", "l", defaultLayoutName, "layout to use")
monitorClusterCmd.Flags().BoolVarP(&showAllPanels, "show-panels", "", false, "show all available panels")
monitorClusterCmd.Flags().BoolVarP(&ignoreRESTErrors, "ignore-errors", "I", false, "ignore errors after initial refresh")
monitorClusterCmd.Flags().BoolVarP(&disablePadding, "disable-padding", "D", false, "disable padding of panels by default")
monitorClusterCmd.Flags().StringVarP(&serviceName, serviceNameOption, "S", "", serviceNameDescription)
monitorClusterCmd.Flags().StringVarP(&selectedCache, "cache-name", "C", "", "cache name")
monitorClusterCmd.Flags().StringVarP(&selectedTopic, "topic-name", "T", "", "topic name")
Expand Down