Skip to content

Conversation

@Sanne
Copy link
Contributor

@Sanne Sanne commented Mar 19, 2019

Fixes ##1087

I'm a Red Hat employee so I believe I won't need to sign an individual contributor agreement.

It's my first contribution. Please let me know if I should do anything else; I'm wondering also if I should add a regression test? I could use a pointer to an example of how you want such tests structured.

Thanks!

@graalvmbot
Copy link
Collaborator

Hello Sanne Grinovero, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address sanne -(at)- hibernate -(dot)- org. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

@Sanne
Copy link
Contributor Author

Sanne commented Mar 19, 2019

@graalvmbot I'm a Red Hat employee so I believe I won't need to sign an individual contributor agreement.

@cstancu
Copy link
Member

cstancu commented Mar 19, 2019

@Sanne I updated the OCA signatory list with your email.

@Sanne
Copy link
Contributor Author

Sanne commented Mar 19, 2019

thanks @cstancu !

@graalvmbot
Copy link
Collaborator

Sanne Grinovero has signed the Oracle Contributor Agreement (based on email address sanne -(at)- hibernate -(dot)- org) so can contribute to this repository.

@Sanne Sanne force-pushed the SocketSO_LINGER branch from 5d3c65a to 8d2c98c Compare March 20, 2019 00:09
@Sanne
Copy link
Contributor Author

Sanne commented Mar 20, 2019

pushed an improved commit, after feedback on #1087

@dougxc dougxc merged commit 8d2c98c into oracle:master Mar 21, 2019
@Sanne Sanne deleted the SocketSO_LINGER branch April 3, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants