Skip to content

[GR-70868] Fix wrong signature in NativeGCStackWalker. #12386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2025
Merged

[GR-70868] Fix wrong signature in NativeGCStackWalker. #12386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...ratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/gc/shared/NativeGCStackWalker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ public NativeGCStackWalker() {
funcFreeThreadStackFrames = CEntryPointLiteral.create(NativeGCStackWalker.class, "freeThreadStackFrames", Isolate.class, IsolateThread.class, StackFramesPerThread.class);

if (ContinuationSupport.isSupported()) {
funcFetchContinuationStackFrames = CEntryPointLiteral.create(NativeGCStackWalker.class, "fetchContinuationStackFrames", Isolate.class, PointerBase.class, Pointer.class);
funcFreeContinuationStackFrames = CEntryPointLiteral.create(NativeGCStackWalker.class, "freeContinuationStackFrames", Isolate.class, PointerBase.class, StackFrames.class);
funcFetchContinuationStackFrames = CEntryPointLiteral.create(NativeGCStackWalker.class, "fetchContinuationStackFrames", Isolate.class, Pointer.class);
funcFreeContinuationStackFrames = CEntryPointLiteral.create(NativeGCStackWalker.class, "freeContinuationStackFrames", Isolate.class, StackFrames.class);
} else {
funcFetchContinuationStackFrames = null;
funcFreeContinuationStackFrames = null;
Expand Down Expand Up @@ -134,7 +134,7 @@ public static void freeThreadStackFrames(@SuppressWarnings("unused") Isolate iso
@Uninterruptible(reason = "GC may only call uninterruptible code.")
@CEntryPoint(include = UseNativeGCAndContinuations.class, publishAs = Publish.NotPublished)
@CEntryPointOptions(prologue = InitializeReservedRegistersForUnattachedThread.class, epilogue = CEntryPointOptions.NoEpilogue.class)
public static StackFrames fetchContinuationStackFrames(@SuppressWarnings("unused") Isolate isolate, @SuppressWarnings("unused") PointerBase heapBase, Pointer storedContinuation) {
public static StackFrames fetchContinuationStackFrames(@SuppressWarnings("unused") Isolate isolate, Pointer storedContinuation) {
StoredContinuation s = (StoredContinuation) storedContinuation.toObject();
ContinuationStackFrameCollectorData data = StackValue.get(ContinuationStackFrameCollectorData.class);
ContinuationStackFrameCollector.initialize(data);
Expand All @@ -145,7 +145,7 @@ public static StackFrames fetchContinuationStackFrames(@SuppressWarnings("unused
@Uninterruptible(reason = "May be called by an unattached thread (during or outside of a safepoint).")
@CEntryPoint(include = UseNativeGCAndContinuations.class, publishAs = Publish.NotPublished)
@CEntryPointOptions(prologue = InitializeReservedRegistersForUnattachedThread.class, epilogue = CEntryPointOptions.NoEpilogue.class)
public static void freeContinuationStackFrames(@SuppressWarnings("unused") Isolate isolate, @SuppressWarnings("unused") PointerBase heapBase, StackFrames stackFrames) {
public static void freeContinuationStackFrames(@SuppressWarnings("unused") Isolate isolate, StackFrames stackFrames) {
NullableNativeMemory.free(stackFrames);
}

Expand Down