[GR-69628] Add new UnsupportedPlatformException For Crema. #12391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erforming analysis lookup Co-authored-by: Gilles Duboscq <gilles.m.duboscq@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite simple addition of a new UnsupportedPlatformException exception type that is thrown from analysis when trying to create an element that is not in the platform. Previously, the more general UnsupportedFeatureException was thrown, so we aim at increasing the precision here.
Crema support uptakes this new exception type to allow for a more precise reasoning for catching expected exceptions when looking up declared members when creating resolved types for Crema.
Note that this new exception could potentially be thrown from other places as well, but I think this should be left as a follow-up for a core native image team member if relevant.