Skip to content

Conversation

@lukasstadler
Copy link
Member

without this change, methods that use the text map (to query line numbers, etc.) may fail or produce wrong results after the source's contents are updated.

@jtulach
Copy link
Contributor

jtulach commented Mar 3, 2016

JT01: could a test demonstrating the problem be part of the fix?

@lukasstadler
Copy link
Member Author

I added some tests and fixed a second, related problem that showed up.
(Source.fromFileName did not update the contents if the file name is relative)

lukasstadler added a commit that referenced this pull request Mar 9, 2016
clear text map when updating code in ClientManagedFileSource
@lukasstadler lukasstadler merged commit c9dc9cb into oracle:master Mar 9, 2016
@lukasstadler lukasstadler deleted the source_setcode_fix branch March 9, 2016 11:08
dougxc pushed a commit that referenced this pull request Jun 17, 2016
…E.COM/truffle:feature/root-node-name to master

* commit 'fe928cb77f3db738c8837d7c4f321da57b6209bc':
  RoodNode:  Javadoc fix
  RootNode.getName() upgraded Javadoc
  Add RootNode.getName() to support tooling, expected to hold a method or procedure name to identify the AST, for example in stack traces.  Additional SLDebugTest checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants