tlshd: fix priority cache initialization #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 9253f9d added the use of the @System keyword as the initial keyword in the priority string used by tlshd. Unfortunately @System doesn't appear to work on systems that do not have a system-wide library configuration set up. Instead of trying to pick an initial keyword that will work on all systems, let's instead use gnutls_priority_init2() with the GNUTLS_PRIORITY_INIT_DEF_APPEND flag instead. That will *append* our priority string to the default options. Fixes: 9253f9d ("tlshd: Fix priority string to allow PQC") Signed-off-by: Scott Mayhew <smayhew@redhat.com> Tested-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Reviewed-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 9253f9d added the use of the @System keyword as the initial keyword in the priority string used by tlshd. Unfortunately @System doesn't appear to work on systems that do not have a system-wide library configuration set up.
Instead of trying to pick an initial keyword that will work on all systems, let's instead use gnutls_priority_init2() with the GNUTLS_PRIORITY_INIT_DEF_APPEND flag instead. That will append our priority string to the default options.
Fixes: 9253f9d ("tlshd: Fix priority string to allow PQC")
Tested-by: Alistair Francis alistair.francis@wdc.com
Reviewed-by: Alistair Francis alistair.francis@wdc.com
Reviewed-by: Hannes Reinecke hare@suse.de