chore: reduce FPs in decode-and-execute by removing file write and network connection sinks #1237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Many false positives were being observed from decoded base64 data flowing through to file writes and network connections, both sinks in the
obfuscation_decode-and-executerule. This PR removes these sinks and finds little-to-no detection capability is lost and false positives are reduced.Description of changes
File writes and network connection sinks are removed from
obfuscation_decode-and-execute, and the tests are updated accordingly. This change was run on a set of malicious and trusted packages, and in comparison found 0 detections (0 false positives) for trusted packages, and only 2 less detections on the malicious packages.Checklist
verifiedlabel should appear next to all of your commits on GitHub.