Skip to content

Conversation

@karl-anthony-ng
Copy link
Contributor

Fixes the following...

  • PDPDEVTOOL-5736: [NSN] vscode-extension fails to authenticate via m2m against scrumboxes
  • Improve Command Paletter behavior for selecting the Private Key File.

@karl-anthony-ng karl-anthony-ng added the bug Something isn't working label Jul 26, 2024
@karl-anthony-ng karl-anthony-ng self-assigned this Jul 26, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 26, 2024
}

private async getPrivateKeyFilePath() {
if (!await window.showQuickPick(['Select private key file'], {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use translation service for string values.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could reuse a modified version of SETUP_ACCOUNT_CREATE_M2M_SELECT_PRIVATE_KEY_FILE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about. Pushed changes.

@davidecorreu davidecorreu merged commit 1d19506 into dev Jul 26, 2024
@davidecorreu davidecorreu deleted the feature/PDPDEVTOOL-5587-vscode-authenticateci branch July 26, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants