pdpdevtool 6317 dev assist avoid to stop button when proxy server error #972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
packages/vscode-extension/src/startup/DevAssistConfiguration.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+218
to
+225
| const buttonsAndActions: { buttonMessage: string, buttonAction: () => void }[] = [ | ||
| { | ||
| buttonMessage: translationService.getMessage(DEVASSIST_SERVICE.SEE_DETAILS_BUTTON), | ||
| buttonAction: () => output.show(), | ||
| }, | ||
| ]; | ||
| vsNotificationService.showCommandErrorWithSpecificButtonsAndActions(errorMessage, buttonsAndActions); | ||
| }; |
Member
There was a problem hiding this comment.
Optional: maybe we could go for the MessageService.showCommandError() ?
Idk if it makes more sense since the code would be simpler but this is technically not a command output..
TheJorgeBorras
approved these changes
Nov 13, 2025
davidecorreu
approved these changes
Nov 14, 2025
davidecorreu
deleted the
bugfix/PDPDEVTOOL-6317-DevAssist-Fix-Stopped-Button-Server-Error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.