Fix Booleans at njsDbObject_transformFromOracle #1190
Conversation
1. Support 'PL/SQL BOOLEAN' at tranformation from DBObject to Javascript values. Signed-off-by: Diego Arce <Diego@arce.cr>
|
Can you point me at your OCA entry? |
I emailed it in few hours ago. |
|
That's great! I'll ask the OCA team to keep an eye out for it. |
1. Support 'PL/SQL BOOLEAN' as OUT parameter to Javascript value. Signed-off-by: Diego Arce <Diego@arce.cr>
1. Support bind 'PL/SQL BOOLEAN' type as IN parameter in PL/SQL store procedures. Signed-off-by: Diego Arce <Diego@arce.cr>
1. Support 'PL/SQL BOOLEAN' at tranformation to DBObject from Javascript values. Signed-off-by: Diego Arce <Diego@arce.cr>
src/njsVariable.c
Outdated
| case DPI_ORACLE_TYPE_BOOLEAN: | ||
| vars[i].varTypeNum = DPI_ORACLE_TYPE_BOOLEAN; | ||
| vars[i].nativeTypeNum = DPI_NATIVE_TYPE_BOOLEAN; | ||
| break; |
There was a problem hiding this comment.
This section is not needed as booleans cannot be fetched. They can only be used in PL/SQL.
src/njsVariable.c
Outdated
| case DPI_ORACLE_TYPE_BLOB: | ||
| return NJS_DATATYPE_BLOB; | ||
| case DPI_ORACLE_TYPE_BOOLEAN: | ||
| return NJS_DATATYPE_BOOLEAN; |
There was a problem hiding this comment.
This section is not needed as booleans cannot be fetched. They can only be used in PL/SQL.
|
@arcezd thanks for getting the OCA submitted. You can see @anthony-tuininga has some comments; more on this below. If you're not aware of the process we use, we'll merge your PR to a private git repo (where we work on things like not-yet released Oracle DB features), and then merge back to GitHub, and make a release. For timing reasons, don't worry about making the trivial changes noted by @anthony-tuininga. He'll make them when we merge the PR. We'll add tests and doc too. |
Signed-off-by: Diego Arce <Diego@arce.cr>
|
@arcezd this finally landed in node-oracledb 4.2. It coincided nicely with the other bind changes. Thanks! |
3 participants
Signed-off-by: Diego Arce Diego@arce.cr
#1189