Retry request on specific authentication errors. #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some Instance Principal cases, the security token returned from OCI Identity may have a very short expiration. This change removes the expiration check, and allows a single retry on requests that get specific authN errors. It also adds trace-level logging of authentication token details.
oracle-contributor-agreement
bot
added
the
OCA Verified
gmfeinberg
reviewed
Jan 4, 2023
| /* allow a single retry on clock skew / auth errors */ | ||
| String msg = iae.getMessage(); | ||
| if ((msg.contains("clock skew") == false && | ||
| msg.contains("request signature is invalid") == false) || |
Contributor
There was a problem hiding this comment.
This would not do the right thing if IAM starts returning expired token exceptions. See the code I posted in slack. Look at the possible errors based on that code. It may not be worth the check on the message and just make this "if (kvRequest.getNumRetries() > 0)".
That is, I don't see a path where this exception happens where we wouldn't want to retry once
…bugfix/instance_principal_expirations
gmfeinberg
reviewed
Jan 5, 2023
| /* allow a single retry on clock skew errors */ | ||
| if (iae.getMessage().contains("clock skew") == false || | ||
| kvRequest.getNumRetries() > 0) { | ||
| /* allow a single retry on clock skew / auth errors */ |
Contributor
There was a problem hiding this comment.
maybe comment that these are errors indicating actual invalid/expired auth info vs a permission-related error
gmfeinberg
previously approved these changes
Jan 5, 2023
gmfeinberg
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some Instance Principal cases, the security token returned from OCI Identity may have a very short expiration. This change removes the expiration check, and allows a single retry on requests that get specific authN errors.
It also adds trace-level logging of authentication token details.