Skip to content

UT Coverage Improvement #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2023
Merged

UT Coverage Improvement #7

merged 2 commits into from
Jul 3, 2023

Conversation

@Inbaraj-S
Copy link
Contributor

  • Includes framework update on client code
  • Mocking client code for UT
  • Additional UT's

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 19, 2023
@Inbaraj-S Inbaraj-S requested a review from nirpai June 19, 2023 08:25
@coveralls
Copy link

coveralls commented Jun 19, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5343765858

  • 191 of 572 (33.39%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+30.8%) to 57.401%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/auth/auth_service.go 13 15 86.67%
pkg/server/server.go 0 3 0.0%
pkg/loadbalancer/loadbalancer.go 23 27 85.19%
pkg/controllers/ingress/ingress.go 17 34 50.0%
pkg/certificate/util.go 117 148 79.05%
pkg/util/testutil.go 0 324 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/ingress/ingress.go 1 52.41%
Totals Coverage Status
Change from base Build 5199009087: 30.8%
Covered Lines: 2005
Relevant Lines: 3493
💛 - Coveralls

nirpai
nirpai reviewed Jun 22, 2023
View reviewed changes
pkg/controllers/routingpolicy/routingpolicy_test.go Outdated

func (m MockLoadBalancerClient) DeleteBackendSet(ctx context.Context, request ociloadbalancer.DeleteBackendSetRequest) (ociloadbalancer.DeleteBackendSetResponse, error) {
//TODO implement me
panic("implement me")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave this empty and remove panic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@Inbaraj-S Inbaraj-S merged commit af092f4 into main Jul 3, 2023
@Inbaraj-S Inbaraj-S deleted the UT-sdk-update branch July 5, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirpai nirpai nirpai approved these changes

Assignees

No one assigned

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Inbaraj-S @coveralls @nirpai