Skip to content

Updated config validator function to check for None values #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Updated config validator function to check for None values #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/oci/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def validate_config(config, **kwargs):
errors = {}
for required_key in REQUIRED:
fallback_key = REQUIRED_FALLBACKS.get(required_key)
if required_key not in config and fallback_key not in config:
if (required_key not in config or config[required_key] is None) and (fallback_key not in config or config[fallback_key] is None):
# If region is not provided, check the env variable
if required_key == REGION_KEY_NAME:
logger.debug("Region not found in config, checking environment variable {}".format(REGION_ENV_VAR_NAME))
Expand Down