Small changes to allow showoci to be imported by wrapper #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add initialization of data structures to __init__ routines of classes. Add the ability to call the argument parser with a command line built in a calling routine. This allows a wrapper to build command lines.
adizohar
suggested changes
Apr 5, 2022
adizohar
suggested changes
Apr 5, 2022
Two updates per request from owner. Changed return False to return None in the showoci.set_parter_arguments routine Fixed typos/spelling errors in Initiate comments
adizohar
suggested changes
Apr 5, 2022
Member
adizohar
left a comment
adizohar
left a comment
There was a problem hiding this comment.
Hi , Almost there,
Regards the except, you must use class for exception, please change to:
except Exception:
for showoci.py add empty line at the end of the file
Thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes allowing the showoci code to be imported and called from a wrapper. The changes include:
Setting the main routine to only be called if showoci.py is called from the command line
Initiating data objects in the init routine so that they are set every time the class is instantiated
Adding optional argument to the argument parser so taht command lines can be built programmatically