Skip to content

Conversation

@marcocanto
Copy link
Member

Signed-off-by: Marco Canto marco.canto@oracle.com

Signed-off-by: Marco Canto <marco.canto@oracle.com>
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Aug 28, 2023
@adizohar
Copy link
Member

Hi Marco
Thank you very much for creating this functionality
In order to pull the request, please amend the file to be consistent with flake8 standards
You can ignore E501 and W504

You have below issues:

object_storage_list_folders.py:324:21: W503 line break before binary operator
object_storage_list_folders.py:325:21: W503 line break before binary operator
object_storage_list_folders.py:326:21: W503 line break before binary operator
object_storage_list_folders.py:327:21: W503 line break before binary operator
object_storage_list_folders.py:328:21: W503 line break before binary operator
object_storage_list_folders.py:343:13: W503 line break before binary operator
object_storage_list_folders.py:344:13: W503 line break before binary operator
object_storage_list_folders.py:345:13: W503 line break before binary operator

Thank you

Signed-off-by: Marco Canto <marco.canto@oracle.com>
Copy link
Member

@adizohar adizohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve adding the new file with new functionality

@adizohar
Copy link
Member

Approved

Signed-off-by: Marco Canto <marco.canto@oracle.com>
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Aug 28, 2023
Copy link
Member

@adizohar adizohar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to merge

@bhagwatvyas bhagwatvyas merged commit 486fc59 into oracle:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants