Skip to content

Conversation

vladak
Copy link
Member

@vladak vladak commented Oct 6, 2020

This change removes the 'Completed in ' message from the search results page. I think it is not necessary and clutters the UI. If the user is interested in the latency for debugging purposes, he can always use e.g. Web console in Firefox or such. For admins this value is available via the monitoring endpoint.

@vladak vladak added the UI label Oct 6, 2020
Copy link
Contributor

@ahornace ahornace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even Google shows the time on the search -> I think it might be sometimes insightful. However, in OpenGrok this line was too big and I completely agree that it's nicer without it.

@vladak
Copy link
Member Author

vladak commented Oct 6, 2020

Even Google shows the time on the search -> I think it might be sometimes insightful. However, in OpenGrok this line was too big and I completely agree that it's nicer without it.

I've been trying to make the UI minimal over the course of years and this makes sense to me.

@tulinkry
Copy link
Contributor

tulinkry commented Oct 6, 2020

I think this change is ok, the ui user is most of the time not really interested how much time a query took at the server. The round trip is the important number and that is in the browser console.

@vladak
Copy link
Member Author

vladak commented Oct 6, 2020

I think this change is ok, the ui user is most of the time not really interested how much time a query took at the server. The round trip is the important number and that is in the browser console.

Yeah, I think the number can serve as a sort of advertisement ("look how fast this service is", except when it is not) however that is not our goal I think. The latency should be a concern to whoever is running the service and there is monitoring for that. If anyone is really interested in making sure the latency is within a limit, various monitoring tools on various levels offer this sort of capability (Micrometer can configure Meters with SLA, Prometheus has alerting capability as well as Grafana etc.).

@vladak vladak force-pushed the web_completed_latency_farewell branch from f2bd0b0 to cb80267 Compare October 6, 2020 18:13
@vladak vladak merged commit 7416c09 into oracle:master Oct 6, 2020
@vladak vladak deleted the web_completed_latency_farewell branch October 6, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants