Skip to content

remove 'Completed in <duration>' message from the UI #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2020
Merged

remove 'Completed in <duration>' message from the UI #3266

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
986974b
remove 'Completed in <duration>' message from the UI
Oct 6, 2020
cb80267
remove all starttime references
Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions opengrok-web/src/main/webapp/search.jsp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,11 @@ include file="projects.jspf"
{
PageConfig cfg = PageConfig.get(request);

long starttime = System.currentTimeMillis();

SearchHelper searchHelper = cfg.prepareSearch();
// N.b. searchHelper.destroy() is called via
// WebappListener.requestDestroyed() on presence of the following
// REQUEST_ATTR.
request.setAttribute(SearchHelper.REQUEST_ATTR, searchHelper);
request.setAttribute("search.jsp-query-start-time", starttime);
searchHelper.prepareExec(cfg.getRequestedProjects()).executeQuery().prepareSummary();
// notify suggester that query was searched
SuggesterServiceFactory.getDefault().onSearch(cfg.getRequestedProjects(), searchHelper.query);
Expand Down Expand Up @@ -150,7 +147,6 @@ include file="menu.jspf"
{
PageConfig cfg = PageConfig.get(request);
SearchHelper searchHelper = (SearchHelper) request.getAttribute(SearchHelper.REQUEST_ATTR);
Long starttime = (Long) request.getAttribute("search.jsp-query-start-time");
// TODO spellchecking cycle below is not that great and we only create
// suggest links for every token in query, not for a query as whole
if (searchHelper.errorMsg != null) {
Expand Down Expand Up @@ -207,8 +203,6 @@ include file="menu.jspf"
<li>Try more general keywords.</li>
<li>Use 'wil*' cards if you are looking for partial match.</li>
</ul>
<p><b>Completed in <%= System.currentTimeMillis() - starttime
%> milliseconds</b></p>
<%
} else {
int start = searchHelper.start;
Expand All @@ -232,8 +226,7 @@ include file="menu.jspf"
Results.prettyPrint(out, searchHelper, start, start + thispage);
%>
</table>
<p><b>Completed in <%= System.currentTimeMillis() - starttime
%> milliseconds</b></p><%
<%
if (slider.length() > 0) {
%>
<p class="slider"><%= slider %></p><%
Expand Down