Ensure that a proper error messsage is raised for unsigned integers in

addition to signed integers; add appropriate tests.

Author: anthony-tuininga

src/oracledb/impl/arrow/array.pyx

@@ -266,7 +266,15 @@ cdef class ArrowArrayImpl:
         """
         Append an unsigned integer to the array.
         """
-        _check_nanoarrow(ArrowArrayAppendUInt(self.arrow_array, value))
+        cdef:
+            str arrow_type
+            int result
+        result = ArrowArrayAppendUInt(self.arrow_array, value)
+        if result == EINVAL:
+            arrow_type = ArrowTypeString(self.schema_impl.arrow_type).decode()
+            errors._raise_err(errors.ERR_INVALID_INTEGER, value=value,
+                              arrow_type=arrow_type)
+        _check_nanoarrow(result)
 
     cdef int append_vector(self, array.array value) except -1:
         """

tests/test_9300_dataframe_requested_schema.py

@@ -719,3 +719,29 @@ def test_9325(db_type_name, dtype, conn):
     assert tab.field("STRING_COL").type == dtype
     for fetched_value in tab["STRING_COL"]:
         assert fetched_value.as_py() == value
+
+
+@pytest.mark.parametrize(
+    "dtype,value",
+    [
+        (pyarrow.int8(), -129),
+        (pyarrow.int8(), 128),
+        (pyarrow.int16(), -32769),
+        (pyarrow.int16(), 32768),
+        (pyarrow.int32(), -2147483649),
+        (pyarrow.int32(), 2147483648),
+        (pyarrow.uint8(), -1),
+        (pyarrow.uint8(), 256),
+        (pyarrow.uint16(), -1),
+        (pyarrow.uint16(), 65536),
+        (pyarrow.uint32(), -1),
+        (pyarrow.uint32(), 4294967296),
+    ],
+)
+def test_9326(dtype, value, conn, test_env):
+    "9326 - fetch_df_all() for out of range integer values"
+    requested_schema = pyarrow.schema([("VALUE", dtype)])
+    with test_env.assert_raises_full_code("DPY-4038"):
+        conn.fetch_df_all(
+            "select :1 from dual", [value], requested_schema=requested_schema
+        )

tests/test_9400_dataframe_requested_schema_async.py

@@ -742,3 +742,29 @@ async def test_9425(db_type_name, dtype, async_conn):
     assert tab.field("STRING_COL").type == dtype
     for fetched_value in tab["STRING_COL"]:
         assert fetched_value.as_py() == value
+
+
+@pytest.mark.parametrize(
+    "dtype,value",
+    [
+        (pyarrow.int8(), -129),
+        (pyarrow.int8(), 128),
+        (pyarrow.int16(), -32769),
+        (pyarrow.int16(), 32768),
+        (pyarrow.int32(), -2147483649),
+        (pyarrow.int32(), 2147483648),
+        (pyarrow.uint8(), -1),
+        (pyarrow.uint8(), 256),
+        (pyarrow.uint16(), -1),
+        (pyarrow.uint16(), 65536),
+        (pyarrow.uint32(), -1),
+        (pyarrow.uint32(), 4294967296),
+    ],
+)
+async def test_9426(dtype, value, async_conn, test_env):
+    "9426 - fetch_df_all() for out of range integer values"
+    requested_schema = pyarrow.schema([("VALUE", dtype)])
+    with test_env.assert_raises_full_code("DPY-4038"):
+        await async_conn.fetch_df_all(
+            "select :1 from dual", [value], requested_schema=requested_schema
+        )