Fix Console History tests #221
Conversation
* refine instance fixtures to use fastest VM
| } | ||
|
|
||
| func (s *ConsoleHistoryResourceCrud) Delete() (e error) { | ||
| e = nil |
There was a problem hiding this comment.
I'm probably missing some context. It looks like this would silently succeed without doing the delete?
There was a problem hiding this comment.
A few lines up in deleteConsoleHistory the return fmt.Errorf("console history resource: console history %v cannot be deleted", d.Id()) line was causing the test to fail even after the test assertion succeeded. It also indicated the resource could not be deleted, this is the pattern for that. Looking at the api docs, there is a DeleteConsoleHistory api--probably added after this was developed a year ago, but I'm more inclined to remove this feature and tests than invest more in it--there is no use case for console history in terraform, it was originally added by mistake.
There was a problem hiding this comment.
Makes sense - I agree that there isn't much of a use case here. If it's possible to log a warning here to say that delete isn't supported, that would be good.
| display_name = "network_name" | ||
| } | ||
| resource "baremetal_core_internet_gateway" "CompleteIG" { |
There was a problem hiding this comment.
Why are these being removed?
There was a problem hiding this comment.
Not used in the test at all--added setup time for fixtures.
…8 to dev
Squashed commit of the following:
commit f924eebeb4d95a3e88bd49f481f0e4b42b73f5aa
Author: Brian Gustafson <brian.gustafson@oracle.com>
Date: Thu May 10 15:42:20 2018 -0700
Reference example in changelog
commit 0fba0039bfa4d57204e622bce057a99d760c111c
Author: Brian Gustafson <brian.gustafson@oracle.com>
Date: Thu May 10 14:32:54 2018 -0700
Changelog for 2.1.8
2 participants
TESTS:
TF_ACC=1 TF_ORACLE_ENV=test ./terraform-plain.sh -timeout 120m -run TestResourceCoreConsoleHistoryTestSuiteTF_ACC=1 TF_ORACLE_ENV=test ./terraform-plain.sh -timeout 120m -run TestDatasourceCoreConsoleHistoryTestSuite