Skip to content

Add host header and version to signing #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2017
Merged

Add host header and version to signing #340

merged 1 commit into from
Oct 31, 2017

Conversation

@briangustafson
Copy link
Member

This is purely a sync of SDK changes.

@briangustafson
Add host header and version to signing
61f1b14 
This is purely a sync of SDK changes.
codycushing
codycushing approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@codycushing codycushing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should create a ticket for adding integration tests to the new region + tenancy APIs in the SDK

@briangustafson briangustafson merged commit 5bcec62 into master Oct 31, 2017
@codycushing codycushing deleted the sync_sdk_header_signing branch December 20, 2017 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parweza parweza Awaiting requested review from parweza

@rcohenma rcohenma Awaiting requested review from rcohenma

@kohashim kohashim Awaiting requested review from kohashim

1 more reviewer

@codycushing codycushing codycushing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@briangustafson @codycushing