Skip to content

Updated the OHS template to handle new OHS base images #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 7, 2022
Merged

Updated the OHS template to handle new OHS base images #225

merged 3 commits into from
Dec 7, 2022

Conversation

@sanjaymantoor
Copy link
Member

@sanjaymantoor sanjaymantoor commented Dec 7, 2022

Updated the OHS template to handle new OHS base images

  • Updated the vmSizeSelect parameter to vmSize
  • Removed the data disk option as new OHS base images are using OS disk only
  • Updated the JDK version and keytool path as per latest OHS base VM images

@oracle-contributor-agreement
Copy link

oracle-contributor-agreement bot commented Dec 7, 2022

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Dec 7, 2022
@sanjaymantoor
Copy link
Member Author

sanjaymantoor commented Dec 7, 2022

Resolved issue #226

@sanjaymantoor sanjaymantoor mentioned this pull request Dec 7, 2022
Closed
edburns
edburns approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@edburns edburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mriccell mriccell merged commit 48d2587 into oracle:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mriccell mriccell mriccell approved these changes

+1 more reviewer

@edburns edburns edburns approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sanjaymantoor @edburns @mriccell