-
Notifications
You must be signed in to change notification settings - Fork 89
update sample to reference Oracle Container Registry #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ontainer Registry instead of Docker Hub
rosemarymarano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor stuff.
…nge' into derek-container-registry-doc-change
samples/docker-domain/Dockerfile
Outdated
| # --------------- | ||
| # FROM store/oracle/weblogic:12.2.1.3 | ||
| FROM store/oracle/weblogic:12.2.1.3-dev | ||
| FROM container-registry.oracle.com/middleware/weblogic:12.2.1.3-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Operator references container-registry.oracle.com/middleware/weblogic:12.2.1.3, we should be consistent across our tools
CarolynRountree
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If JDK not installed, then use another tool to unzip the WDT install image zip. Currently using jar which is not in JRE. Derek said for the image project, he copied zip utility and then removed prior to leaving. Our sample is not using layering, so it will remain in the image.
|
The generic image also has Server JRE weblogic:12.2.1.3, why only the dev image? If we want to be consistent with the operator project then we can use weblogic:12.2.1.3 as in https://oracle.github.io/weblogic-kubernetes-operator/userguide/managing-domains/domain-in-image/base-images/. |
…tch samples in operator project
|
Confirmed that container-registry.oracle.com/middleware/weblogic:12.2.1.3 has JAR. Switching Dockerfile and doc to reference that image. |
Updated sample and Dockerfile to reference Oracle Container Registry