Skip to content

Conversation

@ddsharpe
Copy link
Member

@ddsharpe ddsharpe commented Jun 6, 2019

Updated sample and Dockerfile to reference Oracle Container Registry

rakillen
rakillen previously approved these changes Jun 6, 2019
@ddsharpe ddsharpe requested a review from CarolynRountree June 6, 2019 21:35
Copy link
Contributor

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor stuff.

rakillen
rakillen previously approved these changes Jun 7, 2019
rakillen
rakillen previously approved these changes Jun 25, 2019
# ---------------
# FROM store/oracle/weblogic:12.2.1.3
FROM store/oracle/weblogic:12.2.1.3-dev
FROM container-registry.oracle.com/middleware/weblogic:12.2.1.3-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Operator references container-registry.oracle.com/middleware/weblogic:12.2.1.3, we should be consistent across our tools

Copy link
Contributor

@CarolynRountree CarolynRountree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If JDK not installed, then use another tool to unzip the WDT install image zip. Currently using jar which is not in JRE. Derek said for the image project, he copied zip utility and then removed prior to leaving. Our sample is not using layering, so it will remain in the image.

@mriccell
Copy link
Member

The generic image also has Server JRE weblogic:12.2.1.3, why only the dev image? If we want to be consistent with the operator project then we can use weblogic:12.2.1.3 as in https://oracle.github.io/weblogic-kubernetes-operator/userguide/managing-domains/domain-in-image/base-images/.

@ddsharpe
Copy link
Member Author

Confirmed that container-registry.oracle.com/middleware/weblogic:12.2.1.3 has JAR. Switching Dockerfile and doc to reference that image.

@ddsharpe ddsharpe merged commit 16da3f4 into master Jul 25, 2019
@ddsharpe ddsharpe deleted the derek-container-registry-doc-change branch July 25, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants