-
Notifications
You must be signed in to change notification settings - Fork 216
Mii app patching test #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mii app patching test #1616
Conversation
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/impl/primitive/Command.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/impl/primitive/CommandParams.java
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItWitValidation.java
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItWitValidation.java
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/TestAssertions.java
|
Clean test run on external Jenkins - https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests-10/23/ |
new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
Outdated
Show resolved
Hide resolved
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/impl/Kubernetes.java
|
The current version is clean in external Jenkins run https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests-10/37/. |
new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/TestActions.java
Outdated
Show resolved
Hide resolved
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/impl/Domain.java
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/extensions/ImageBuilders.java
new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
Outdated
Show resolved
Hide resolved
new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
Show resolved
Hide resolved
| @DisplayName("Update the sample-app application to version 2") | ||
| @Slow | ||
| @MustNotRunInParallel | ||
| public void testPatchAppV2() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the new tests in this PR should be added in a new or other existing It class where the domain creation/existence is a prerequisite, then you don't need to order the tests. Here it is assumed that the domain is up and running by ordering the tests where it should have been verified in beforeEach method. This is a late comment in this PR. If everyone agrees, changes can be made in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, and yes, I would prefer address this comment in a different PR.
I still need to understand how to maintain expected order among different test methods without using @order annotation, or between different test classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order for the patching test cases to be fully independent, we need to do three things:
- Move those test methods into a different test class;
- Create a new initial domain in the BeforeAll handler of the new class; instead of using the domain that is created in the first end-to-end test case;
- At the end of each test case, rollback what we have done in the method so that the domain goes back to the initial state, to make the state predictable for the next test case.
Both 2) and 3) will increase the total time of the test suite run, which is what the current approach tries to avoid.
Conflicts: new-integration-tests/src/test/java/oracle/weblogic/kubernetes/TestConstants.java new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/TestActions.java
markxnelson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are still some comments that have not been adequately addressed. my biggest concern is the use of exec() to run kubectl exec. @rjeberhard i approved this, in the interests of getting the good stuff here into the regular test runs, i am willing to overlook some of the not ideal stuff, if you are. i will let you decide whether to merge this as-is, or persist with those last few issues
Uh oh!
There was an error while loading. Please reload this page.