Skip to content

Conversation

@doxiao
Copy link
Member

@doxiao doxiao commented May 3, 2020

  1. Add test case Copy edits to fix minor typos #5 and Removed use of italics for highlighting key terms #6, which patches an existing app or adds an additional app respectively, including verifications of patching, app accessibility, and app continuous availability.
  2. Use Kubernetes client exec api to verify app availability.
  3. Add timeout to the join call in Kubernetes API exec command action.
  4. Cleanup, including removing ItWitValidation.java because its content has been moved into ItMiiDomain.java.

doxiao added 30 commits April 16, 2020 13:23
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/impl/primitive/Command.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/impl/primitive/CommandParams.java
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItWitValidation.java
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItWitValidation.java
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/TestAssertions.java
@doxiao
Copy link
Member Author

doxiao commented May 7, 2020

doxiao added 3 commits May 8, 2020 21:18
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/impl/Kubernetes.java
@doxiao
Copy link
Member Author

doxiao commented May 11, 2020

The current version is clean in external Jenkins run https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-model-in-image-tests-10/37/.

doxiao added 5 commits May 11, 2020 23:57
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/assertions/impl/Domain.java
Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/ItMiiDomain.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/extensions/ImageBuilders.java
@DisplayName("Update the sample-app application to version 2")
@Slow
@MustNotRunInParallel
public void testPatchAppV2() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the new tests in this PR should be added in a new or other existing It class where the domain creation/existence is a prerequisite, then you don't need to order the tests. Here it is assumed that the domain is up and running by ordering the tests where it should have been verified in beforeEach method. This is a late comment in this PR. If everyone agrees, changes can be made in another PR.

Copy link
Member Author

@doxiao doxiao May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and yes, I would prefer address this comment in a different PR.

I still need to understand how to maintain expected order among different test methods without using @order annotation, or between different test classes.

Copy link
Member Author

@doxiao doxiao May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for the patching test cases to be fully independent, we need to do three things:

  1. Move those test methods into a different test class;
  2. Create a new initial domain in the BeforeAll handler of the new class; instead of using the domain that is created in the first end-to-end test case;
  3. At the end of each test case, rollback what we have done in the method so that the domain goes back to the initial state, to make the state predictable for the next test case.

Both 2) and 3) will increase the total time of the test suite run, which is what the current approach tries to avoid.

Conflicts:
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/TestConstants.java
	new-integration-tests/src/test/java/oracle/weblogic/kubernetes/actions/TestActions.java
@doxiao doxiao requested a review from markxnelson May 14, 2020 21:44
Copy link
Member

@markxnelson markxnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are still some comments that have not been adequately addressed. my biggest concern is the use of exec() to run kubectl exec. @rjeberhard i approved this, in the interests of getting the good stuff here into the regular test runs, i am willing to overlook some of the not ideal stuff, if you are. i will let you decide whether to merge this as-is, or persist with those last few issues

@rjeberhard rjeberhard merged commit 898b967 into develop May 17, 2020
@doxiao doxiao deleted the mii-app-patching-test branch July 23, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants