Fix missing error output from WDT compareModel #2351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove outdated comment
tbarnes-us
approved these changes
May 3, 2021
tbarnes-us
left a comment
tbarnes-us
left a comment
There was a problem hiding this comment.
LGTM. I deleted the outdated comment above the change.
rjeberhard
reviewed
May 4, 2021
|
|
||
| # no need to redirect output, -output_dir for compareModel will generate the output file | ||
| ${WDT_BINDIR}/compareModel.sh -oracle_home ${ORACLE_HOME} -output_dir /tmp $1 $2 > /dev/null 2>&1 | ||
| ${WDT_BINDIR}/compareModel.sh -oracle_home ${ORACLE_HOME} -output_dir /tmp $1 $2 > ${WDT_OUTPUT} 2>&1 |
Member
There was a problem hiding this comment.
Is the double space after the > intentional?
rjeberhard
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the missing output from WDT compareModel tool when the tool failed itself and not creating the compare_model_output file, using redirected terminal output instead.