Upgraded terraform and terraform oci provider to 0.12.X version #2353
Conversation
| variable "node_pool_quantity_per_subnet" { default = 2 } | ||
| variable "node_pool_ssh_public_key" { } | ||
| variable "cluster_kubernetes_version" { | ||
| default = "v1.15.7" |
There was a problem hiding this comment.
This default seems off... The default OKE K8s version is 1.19.7 and the minimum is 1.17.9.
There was a problem hiding this comment.
it is overwritten by provided variable in the Tovar file, but I will change it minimum
| } | ||
|
|
||
| variable "node_pool_kubernetes_version" { | ||
| default = "v1.11.5" |
There was a problem hiding this comment.
Similarly, this seems way too low.
| } | ||
|
|
||
| variable "cluster_kube_config_token_version" { | ||
| default = "1.0.0" |
There was a problem hiding this comment.
Is the 1.0 token still supported. They are on 2.0, correct?
marinakog
requested review from
anpanigr,
hzhao-github,
rjeberhard,
vanajamukkara and
xiancao
xiancao
left a comment
xiancao
left a comment
There was a problem hiding this comment.
LG, some minor comments.
| node_image_name = var.node_pool_node_image_name | ||
| node_shape = var.node_pool_node_shape | ||
|
|
||
| #subnet_ids = ["${oci_core_subnet.oke-subnet-worker-1.id}", "${oci_core_subnet.oke-subnet-worker-2.id}","${oci_core_subnet.oke-subnet-worker-3.id}"] |
There was a problem hiding this comment.
I left them intentionally , so we can switch between2 and 3 nodes in cluster
| node_image_name = var.node_pool_node_image_name | ||
| node_shape = var.node_pool_node_shape | ||
|
|
||
| #subnet_ids = ["${oci_core_subnet.oke-subnet-worker-1.id}", "${oci_core_subnet.oke-subnet-worker-2.id}","${oci_core_subnet.oke-subnet-worker-3.id}"] |
There was a problem hiding this comment.
I left them intentionally , so we can switch between2 and 3 nodes in cluster
| node_image_name = var.node_pool_node_image_name | ||
| node_shape = var.node_pool_node_shape | ||
|
|
||
| #subnet_ids = ["${oci_core_subnet.oke-subnet-worker-1.id}", "${oci_core_subnet.oke-subnet-worker-2.id}","${oci_core_subnet.oke-subnet-worker-3.id}"] |
There was a problem hiding this comment.
I left them intentionally , so we can switch between2 and 3 nodes in cluster
6 participants
https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/258/