Skip to content

change the assert for admin port change #2355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021
Merged

change the assert for admin port change #2355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3660a6
Assert the exit code non zero result
sankarpn Apr 19, 2021
5335a5c
Merge branch 'main' of https://github.com/oracle/weblogic-kubernetes-…
sankarpn May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions integration-tests/src/test/java/oracle/weblogic/kubernetes/ItIntrospectVersion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,13 +122,11 @@
import static oracle.weblogic.kubernetes.utils.WLSTUtils.executeWLSTScript;
import static org.assertj.core.api.Assertions.assertThat;
import static org.awaitility.Awaitility.with;
import static org.junit.jupiter.api.Assertions.assertAll;
import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.fail;

/**
* Tests related to introspectVersion attribute.
Expand Down Expand Up @@ -572,14 +570,8 @@ public void testDomainIntrospectVersionRolling() {

ExecResult execResult = assertDoesNotThrow(() -> execCommand(introDomainNamespace, adminServerPodName, null, true,
"/bin/sh", "-c", curlCmd));
if (execResult.exitValue() == 0) {
logger.info("\n HTTP response is \n " + execResult.toString());
assertAll("Check that the HTTP response is 200",
() -> assertTrue(execResult.toString().contains("HTTP/1.1 200 OK"))
);
} else {
fail("Failed to change admin port number " + execResult.stderr());
}
assertTrue(execResult.exitValue() == 0 || execResult.stderr() == null || execResult.stderr().isEmpty(),
"Failed to change admin port number");

patchDomainResourceWithNewIntrospectVersion(domainUid, introDomainNamespace);

Expand Down