-
Notifications
You must be signed in to change notification settings - Fork 216
Cross Domain RMI communcation with Message Driven Bean (istio/non-istio) #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FYI, no "properties" needed assuming domain uid and namespace are 'DNS name' compliant (no "_", no caps):
|
|
|
||
| // Now that we got the namespaces for both the domains, we need to update the model properties | ||
| // file with the namespaces. For cross domain transaction to work, we need to have the externalDNSName | ||
| // file with the namespaces. For a cross-domain transaction to work, we need to have the externalDNSName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For cross domain transaction is correct - do not need a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I run grammerly apps on the code, it suggested cross domain -> cross-domain
|
|
||
| assertDoesNotThrow(() -> copyFolder( | ||
| mdbSrcDir.toString(), mdbDestDir.toString()), | ||
| "Could not mdbtopic application directory"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not copy mdbtopic .....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| String curlRequest = String.format("curl -v --show-error --noproxy '*' " | ||
| + "http://%s:%s/cdttxservlet/cdttxservlet?namespaces=%s,%s", | ||
| K8S_NODEPORT_HOST, domain1AdminServiceNodePort, domain1Namespace, domain2Namespace); | ||
| K8S_NODEPORT_HOST, admin1ServiceNodePort, domain1Namespace, domain2Namespace); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the original name - domain1AdminServiceNodePort better since it tells me immediately that it is the admin server belonging to domain1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| } | ||
|
|
||
| /* | ||
| * This test verifies a cross-domain MessageDrivenBean communication |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont think you need "a"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| package application; | ||
|
|
||
| import java.io.IOException; | ||
| import java.io.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you import specific classes the servlet needs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
|
||
| package application; | ||
|
|
||
| import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import only classes needed by this servlet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
bhavaniravichandran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This test verifies cross domain MessageDrivenBean communication (Istio/Non-Istio)
A transacted MDB on Domain D1 listen on a replicated Distributed Topic on Domain D2.
The MDB is deployed to cluster on domain D1 with MessagesDistributionMode set to One-Copy-Per-Server.
The OnMessage() routine sends a message to local queue on receiving the message.
An application servlet is deployed to Administration Server on D1 which send/receive message from a JMS destination based on a given URL.
Usecase
(a) app servlet send message to Distributed Topic on D2
(b) mdb puts a message into local Queue for each received message
(c) make sure local Queue gets 2X times messages sent to Distributed Topic
(d) make sure the each MDB instance receives equal number of messsages
Since the MessagesDistributionMode is set to One-Copy-Per-Server and targeted to a cluster of two servers, onMessage() will be triggered for or both instance of MDB for a message sent to Distributed Topic
In Progress
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4946
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4962/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/4965/