Don't remove other conditions when adding ConfigChangesPendingRestart #2447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbarnes-us
reviewed
Jul 8, 2021
operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainStatus.java
Show resolved
Hide resolved
|
The change LGTM given Russ' answer to my question. I recommend getting sign-off from Ryan, Dongbo, and Johnny. |
doxiao
suggested changes
Jul 8, 2021
operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainConditionType.java
Show resolved
Hide resolved
operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainStatus.java
Show resolved
Hide resolved
operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainStatus.java
Show resolved
Hide resolved
doxiao
approved these changes
Jul 8, 2021
Member
doxiao
left a comment
doxiao
left a comment
There was a problem hiding this comment.
LGTM. thanks for your explanations.
rjeberhard
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a condition of type ConfigChangesPendingRestart is currently removing any other statuses. This fixes that and does some code cleanup.