-
Notifications
You must be signed in to change notification settings - Fork 216
OWLS-90955 - Document expected file merge order for auxiliary images defined at various scopes #2478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…at a particular scope and at different scopes.
rosemarymarano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few edits. Plus I noticed that in the Model Files doc, we have two headings with no intervening text, a no-no:
Model file macros
Using secrets in model files
| - [Step 4: Invoke the web application](#step-4-invoke-the-web-application) | ||
|
|
||
| ### Introduction | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The advantages of auxiliary image -> (Either) The advantages of an auxiliary image OR The advantages of auxiliary images
| Each array entry must define an `image` and `volume` | ||
| where `image` is the name of an auxiliary image | ||
| and the `volume` is the name of an [auxiliary image volume](#auxiliary-volumes-and-paths) | ||
| as described above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as described above. -> as described previously.
| where `image` is the name of an auxiliary image | ||
| and the `volume` is the name of an [auxiliary image volume](#auxiliary-volumes-and-paths) | ||
| as described above. | ||
| You can optionally also specify an `imagePullPolicy`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can optionally also specify -> Optionally , you can also specify
| You can optionally also specify an `imagePullPolicy`, | ||
| which defaults to `Always` if the `image` ends in `:latest` and to `IfNotPresent`, | ||
| otherwise. | ||
| You can also optionally customize |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also optionally customize -> Also, optionally, you can customize
| You can also optionally customize | ||
| the command that is used to merge (copy) the auxiliary image's files | ||
| into the auxiliary image volume during pod startup (this is rarely | ||
| needed, see [Performing replaces instead of merges](#performing-replaces-instead-of-merges) below for an example). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see Performing replaces instead of merges below for an example). -> see Performing replaces instead of merges for an example).
below (adv) (prep) Do not use to refer to material that can be found at a later position in a document.
| ms-image-A:v1 (last) | ||
| ``` | ||
|
|
||
| ### Sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under Step 2
Follow these steps to create a auxiliary image -> Follow these steps to create an auxiliary image
On line 625
custom file name in the above command. -> custom file name in the previous command.
The initial draft of the documentation for the merge order of file included in auxiliary images defined at the same scope and at different scopes.