Skip to content

Conversation

@ankedia
Copy link
Member

@ankedia ankedia commented Jul 22, 2021

The initial draft of the documentation for the merge order of file included in auxiliary images defined at the same scope and at different scopes.

@ankedia ankedia requested review from rjeberhard and tbarnes-us July 22, 2021 16:47
@ankedia ankedia marked this pull request as ready for review July 22, 2021 22:23
Copy link
Contributor

@rosemarymarano rosemarymarano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few edits. Plus I noticed that in the Model Files doc, we have two headings with no intervening text, a no-no:
Model file macros
Using secrets in model files

- [Step 4: Invoke the web application](#step-4-invoke-the-web-application)

### Introduction

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advantages of auxiliary image -> (Either) The advantages of an auxiliary image OR The advantages of auxiliary images

Each array entry must define an `image` and `volume`
where `image` is the name of an auxiliary image
and the `volume` is the name of an [auxiliary image volume](#auxiliary-volumes-and-paths)
as described above.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as described above. -> as described previously.

where `image` is the name of an auxiliary image
and the `volume` is the name of an [auxiliary image volume](#auxiliary-volumes-and-paths)
as described above.
You can optionally also specify an `imagePullPolicy`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can optionally also specify -> Optionally , you can also specify

You can optionally also specify an `imagePullPolicy`,
which defaults to `Always` if the `image` ends in `:latest` and to `IfNotPresent`,
otherwise.
You can also optionally customize
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also optionally customize -> Also, optionally, you can customize

You can also optionally customize
the command that is used to merge (copy) the auxiliary image's files
into the auxiliary image volume during pod startup (this is rarely
needed, see [Performing replaces instead of merges](#performing-replaces-instead-of-merges) below for an example).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see Performing replaces instead of merges below for an example). -> see Performing replaces instead of merges for an example).

below (adv) (prep) Do not use to refer to material that can be found at a later position in a document.

ms-image-A:v1 (last)
```

### Sample
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Under Step 2
Follow these steps to create a auxiliary image -> Follow these steps to create an auxiliary image
On line 625
custom file name in the above command. -> custom file name in the previous command.

@rjeberhard rjeberhard merged commit c2dc60b into main Jul 23, 2021
@ankedia ankedia deleted the owls_90955 branch September 22, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants