Add coherence integration test with istio #2485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhao-github
approved these changes
Jul 30, 2021
Contributor
|
LGTM. However, I'd suggest that we add one more test to coherence integration test with istio using managed coherence. That way, we can test istio's LBer feature by associating a Coherence Cluster with WebLogic server clusters. |
| ListenPort: 8100 | ||
| CoherenceClusterSystemResource: CoherenceCluster | ||
| CoherenceMemberConfig: | ||
| UnicastListenAddress: 'coherence-managed-domain-cluster-1-managed-server${id}' |
Member
There was a problem hiding this comment.
I thought you were going to have a domainUID property here instead of hardcoding the domain id here.
Member
Author
There was a problem hiding this comment.
this is a temporary workaround, till we resolve OWLS-91266. This section will be removed once we resolve OWLS-91266.
| ListenPort: 8100 | ||
| CoherenceClusterSystemResource: CoherenceCluster | ||
| CoherenceMemberConfig: | ||
| UnicastListenAddress: 'coherence-managed-domain-cluster-2-managed-server${id}' |
Member
There was a problem hiding this comment.
same comment as above
Member
Author
There was a problem hiding this comment.
this is a temporary workaround, till we resolve OWLS-91266. This section will be removed once we resolve OWLS-91266.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add coherence integration test with istio
The Coherence Integration Test with ISTIO works now with explicit UnicastListenAddress configuration
Ref: https://jira.****/jira/browse/OWLS-91266 ( dependent JIRA )
Also modified existing Coherance test by removing AfterAll() method
External Jenkin Result
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5833 ( Only Coherance Test )
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5836
ItIstioManagedCoherence.testIstioMultiClusterCoherenceDomain fails as the coherence cache count mismatch when ISTIO is enabled. Need to work with coherence team.