Pass credentials to generate OCIR token #2487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpanigr
approved these changes
Jul 29, 2021
bhavaniravichandran
approved these changes
Jul 29, 2021
rjeberhard
reviewed
Jul 29, 2021
| ExecResult result = null; | ||
| try { | ||
| result = ExecCommand.exec(cmd, true); | ||
| logger.info("Running command..\n{0}", cmd.toString()); |
Member
There was a problem hiding this comment.
Let's not log the password :)
Member
Author
There was a problem hiding this comment.
Sure. Removed the logging.
rjeberhard
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a test run deleting the images pushed to OCIR needs to be deleted, the current infra impl doesn't pass the credentials for generating the OCIR repo tokens. The fix involves passing the credentials to the ocirtoke.sh script.
https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/366/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5832/