Refactoring CommonTestUtils class Part1 : OperatorUtils, ImageUtils, LoadBalancerUtils, LogginExporterUtils, MonitoringUtils #2488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marinakog
requested review from
anpanigr,
bhavaniravichandran,
hzhao-github,
sankarpn,
vanajamukkara and
xiancao
and removed request for
bhavaniravichandran
marinakog
changed the title
marinakog
changed the title
maggiehe00
approved these changes
Aug 2, 2021
Contributor
|
LGTM |
sankarpn
reviewed
Aug 2, 2021
Member
sankarpn
left a comment
sankarpn
left a comment
There was a problem hiding this comment.
Hi @marinakog please run the tests against OKE cluster as well.
Contributor
vanajamukkara
left a comment
vanajamukkara
left a comment
There was a problem hiding this comment.
LG, please update with OKE Jenkins results.
hzhao-github
approved these changes
Aug 2, 2021
Contributor
|
LGTM |
Contributor
Author
|
here are OKE results: https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/372 |
rjeberhard
approved these changes
Aug 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring CommonTestUtils class Part1 : OperatorUtils, ImageUtils, LoadBalancerUtils, LogginExporterUtils, MonitoringUtils. Other utils objects will be refactored in part2
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5831/
OKE results:
https://build.weblogick8s.org:8443/job/wko-oke-nightly-seqential/372