Added test for sample script update_domain.sh ( wlst ) #2496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anpanigr
approved these changes
Aug 10, 2021
bhavaniravichandran
suggested changes
Aug 11, 2021
| @DisplayName("Verify the domain on pv, domain in image samples using wlst and wdt and domain lifecycle scripts") | ||
| @IntegrationTest | ||
| class ItWlsSamples { | ||
| public class ItWlsSamples { |
Member
There was a problem hiding this comment.
Can you please remove the public from here and also all the test methods?
Ryan merged #2492 to make this change and you are overwriting this change.
| @MethodSource("paramProvider") | ||
| @DisplayName("Test samples using domain in image") | ||
| void testSampleDomainInImage(String model) { | ||
| public void testSampleDomainInImage(String model) { |
Member
There was a problem hiding this comment.
Remove public - see earlier comment.
| @MethodSource("paramProvider") | ||
| @DisplayName("Test samples using domain in pv") | ||
| void testSampleDomainInPv(String model) { | ||
| public void testSampleDomainInPv(String model) { |
| @Test | ||
| @DisplayName("Test server lifecycle samples scripts") | ||
| void testServerLifecycleScripts() { | ||
| public void testServerLifecycleScripts() { |
| @Test | ||
| @DisplayName("Test server lifecycle samples scripts with constant replica count") | ||
| void testServerLifecycleScriptsWithConstantReplicaCount() { | ||
| public void testServerLifecycleScriptsWithConstantReplicaCount() { |
| @Test | ||
| @DisplayName("Test cluster lifecycle scripts") | ||
| void testClusterLifecycleScripts() { | ||
| public void testClusterLifecycleScripts() { |
| @Test | ||
| @DisplayName("Test domain lifecycle scripts") | ||
| void testDomainLifecycleScripts() { | ||
| public void testDomainLifecycleScripts() { |
| @Test | ||
| @DisplayName("Manage Traefik Ingress Controller with setupLoadBalancer") | ||
| void testTraefikIngressController() { | ||
| public void testTraefikIngressController() { |
| @Test | ||
| @DisplayName("Manage Voyager Ingress Controller with setupLoadBalancer") | ||
| void testVoyagerIngressController() { | ||
| public void testVoyagerIngressController() { |
| @Test | ||
| @DisplayName("Manage Nginx Ingress Controller with setupLoadBalancer") | ||
| void testNginxIngressController() { | ||
| public void testNginxIngressController() { |
Member
|
What is the status of this PR? It is over 4 months old so is it still relevant? If so, then update the PR to make it so that it can be merged with current code. Otherwise, please close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 failures from Jenkins job https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5942 are not caused by this PR