Use unique Oracle DB TCP listener port for every DB creation test run #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhao-github
approved these changes
Aug 10, 2021
| private static String ORACLEDBSUFFIX = null; | ||
| private static LoggingFacade logger = null; | ||
| static String dbUrl; | ||
| static int dbNodePort; |
Contributor
There was a problem hiding this comment.
Is there a reason these two are not declared as private?
Contributor
There was a problem hiding this comment.
I guess this is not from your change :)
Contributor
Author
There was a problem hiding this comment.
Which 2 variables are you referring to? dbUrl and dbNodePort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR i used getNextFreePort() to get unique port for Oracle DB TCP listener port for DB service/pod creation and keep DB service targetPort 1521, since 1521 is hardcoded in the DB image as DB end port.
Sequential test passed at
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5934/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5935/
Parallel test without DB creation issue at
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5936/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5938/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5939/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5941/
After merging to the latest main, sequential passed at
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5962
No DB creation related failure in parallel run
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/5974/