Remove duplicate calls to TestUtils.silenceOperatorLogger #2760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertpatrick
approved these changes
Feb 2, 2022
rjeberhard
approved these changes
Feb 2, 2022
rjeberhard
pushed a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Jun 7, 2023
* Remove duplicate calls to TestUtils.silenceOperatorLogger * Update copyrights
rjeberhard
pushed a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Jun 7, 2023
* Remove duplicate calls to TestUtils.silenceOperatorLogger * Update copyrights
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was caused by multiple calls to TestUtils.silenceOperatorLogger. Each one removes the existing log handlers and adds a new test one. The result was to confuse the special handling of log messages in unit tests. This change removes the duplicates and modifies the call to report an error on an attempt to invoke it more than once in a test.