Backported to 3.4 ItKubernetesEvents changes to remove test dependencies #3008
Conversation
| return domain; | ||
| } | ||
|
|
||
| private static boolean domainHasRollingCondition(Domain domain) { |
There was a problem hiding this comment.
I believe these conditions doesn't exist in 3.4. It will not make the tests to fail, so its fine.
There was a problem hiding this comment.
Let's remove the assertion. It's strange to assert for the lack of a condition that doesn't exist in 3.4.
|
Can you update the pom.xml to replace ItKubernetesEvents to ItKubernetesDomainEvents? |
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Properties; |
There was a problem hiding this comment.
update the copyright of ItKubernetesDomainEvents.java
// Copyright (c) 2022, Oracle and/or its affiliates.
| logger.info("Checking if the admin server {0} is shutdown in namespace {1}", | ||
| adminServerPodName, domainNamespace1); | ||
| checkPodDoesNotExist(adminServerPodName, domainUid, domainNamespace1); | ||
| adminServerPodName, domainNamespace5); |
There was a problem hiding this comment.
You have a lot of changed lines where the only change is that you moved the content over another tab stop? Why? If it's just the configuration of your editor, can you update its formatting so that it doesn't make as many unnecessary changes?
|
Kudos, SonarCloud Quality Gate passed!
|
…ies (oracle#3008) * Backported to 3.4 ItKubernetesEvents changes to remove test dependencies
…ies (#3008) * Backported to 3.4 ItKubernetesEvents changes to remove test dependencies
5 participants
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10327/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10328/