backport triage ItMiiAuxiliaryImage test failure in release/3.4 #3022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzhao-github
approved these changes
May 2, 2022
Contributor
|
LGTM |
Contributor
|
I'm not sure why we need to change method checkDomainEventContainsExpectedMsg of K8sEvnets in release/3.4 to make it different than main branch. Can you please explain. |
Contributor
Author
checkDomainEventContainsExpectedMsg() method only checks the first event that matches the event type, reason, timestamp and etc. For DOMAIN_PROCESSING_FAILED type, there could be multiple events. The logic need to make sure that it checks all matching events. |
|
Kudos, SonarCloud Quality Gate passed!
|
rjeberhard
pushed a commit
to rjeberhard/weblogic-kubernetes-operator
that referenced
this pull request
Apr 14, 2023
…le#3022) * backport triage ItMiiAuxiliaryImage test failure in release/3.4
rjeberhard
pushed a commit
that referenced
this pull request
Apr 19, 2023
* backport triage ItMiiAuxiliaryImage test failure in release/3.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport triage ItMiiAuxiliaryImage test failure in release/3.4
Jenkins result:
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/10353/
https://build.weblogick8s.org:8443/view/all/job/weblogic-kubernetes-operator-kind-new/10352/