Skip to content

Conversation

@sankarpn
Copy link
Member

@sankarpn sankarpn commented May 2, 2022

The tests needs to pass multiple secrets if the base image and auxilary images are coming from different repos, this PR creates secrets for OCR as well as OCIR registries if they are different.

Also this PR fixes the Dockerfile used in ItMiiAuxiliaryImageCluster.java is not substituted with BUSYBOX_IMAGE:TAG locations

BUSYBOX issue fixed

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10355/

All tests in Kind job

https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10367/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10345/

BASE_IMAGES_REPO as OCR
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/10359/

OKD
https://build.weblogick8s.org:8443/job/wko-okd-test/312/

@maggiehe00
Copy link
Contributor

Talked to Sankar and confirmed that he tested multiple repositories/secrets scenario on OKD. Approving this PR.

Copy link
Contributor

@maggiehe00 maggiehe00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@xiancao xiancao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjeberhard rjeberhard merged commit 5514496 into release/3.4 May 3, 2022
@rjeberhard rjeberhard deleted the altranfix-42822 branch May 16, 2022 13:59
rjeberhard pushed a commit to rjeberhard/weblogic-kubernetes-operator that referenced this pull request Apr 14, 2023
…ferent (oracle#3024)

* Create multiple secrets if BASE_IMAGES_REPO and REPO_REGISTRY are different
rjeberhard pushed a commit that referenced this pull request Apr 19, 2023
…ferent (#3024)

* Create multiple secrets if BASE_IMAGES_REPO and REPO_REGISTRY are different
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants