Fix for failing tests in altran certification exercise. #3208
Conversation
…rnetes-operator into altran-fix-061722
anpanigr
left a comment
anpanigr
left a comment
There was a problem hiding this comment.
Can you post the jenkin results with latest release/3.4
…rnetes-operator into altran-fix-061722
…ernetes/ItMiiDomainModelInPV.java
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| String getModelHome() { | ||
| public String getModelHome() { |
There was a problem hiding this comment.
I do not see anything in this PR that requires these visibility options to change. Why did you promote these methods to public?
There was a problem hiding this comment.
When I was debugging the wdt logs folder creation issue I noticed that dumping the domain cr didn't print the modelHome configuration and found these methods without public identifier. After changing the access modifiers I was able to see it in the debug logs.
There was a problem hiding this comment.
Are there other get/set methods that need to be similarly adjusted? How were you doing the dump?
There was a problem hiding this comment.
logger.info(Yaml.dump(domainCR));
I didn't see any other method that needs change.
* Fix for failing tests in altran certification exercise
* Fix for failing tests in altran certification exercise
4 participants
https://build.weblogick8s.org:8443/job/wko-okd-test/383/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/11220/
https://build.weblogick8s.org:8443/job/weblogic-kubernetes-operator-kind-new/11222/