Skip to content

Conversation

@jchermos
Copy link

@jchermos jchermos commented Feb 6, 2019

https://jira.****/jira/browse/OWLS-69849

Create helm repository to be accessed by github project pages. These changes need to be in gh-pages to be served by https://oracle.github.io/weblogic-kubernetes-operator.

These changes contains:

  • Create index.yaml file in operator charts folder.

  • Add packaged helm chart weblogic-operator-2.tgz

juan.hermosillo@oracle.com added 2 commits February 6, 2019 10:31
@jchermos jchermos requested a review from rjeberhard February 6, 2019 19:17
@rjeberhard
Copy link
Member

Hi Carlos,

We need to make some changes to this PR:

  • We aren't using gh_pages, instead our project publishes content under docs from the master branch to https://oracle.github.io/weblogic-kubernetes-operator/.
  • I'd like to generate the Helm chart package as part of the build and copy it to a directory under docs, such as docs/charts
  • Finally, we need to document the steps to use the Helm chart without cloning the repository, e.g.

helm repo add weblogic-operator https://oracle.github.io/weblogic-kubernetes-operator/charts
helm repo update
helm install weblogic-operator/weblogic-operator-2 ...

Copy link
Member

@rjeberhard rjeberhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my earlier message...

@jchermos jchermos changed the base branch from gh-pages to develop February 11, 2019 19:00
@jchermos
Copy link
Author

Hi Carlos,

We need to make some changes to this PR:

* We aren't using gh_pages, instead our project publishes content under `docs` from the master branch to https://oracle.github.io/weblogic-kubernetes-operator/.

* I'd like to generate the Helm chart package as part of the build and copy it to a directory under docs, such as docs/charts

* Finally, we need to document the steps to use the Helm chart without cloning the repository, e.g.

helm repo add weblogic-operator https://oracle.github.io/weblogic-kubernetes-operator/charts
helm repo update
helm install weblogic-operator/weblogic-operator-2 ...

I pushed the changes to generate the helm chart package during build. Where would you like me to put the usage steps?

@jchermos jchermos force-pushed the gh-pages-OWLS-69849 branch from e0fd933 to ab8108e Compare February 13, 2019 20:25
@jchermos
Copy link
Author

@rjeberhard All requested changes done.

@rjeberhard
Copy link
Member

@jchermos, did you see my message in slack this morning? You have done everything I asked for. So, first, thanks. There is an issue that if you build repeatedly, then the helm package and repo index are different every time. So, if we commit this PR, then other developers will constantly see these files change. Sadly, I can't find a set of arguments to helm package that produce the same .tgz file every time and the index has both a created and generated time stamp. Ideas?

@jchermos
Copy link
Author

@jchermos, did you see my message in slack this morning? You have done everything I asked for. So, first, thanks. There is an issue that if you build repeatedly, then the helm package and repo index are different every time. So, if we commit this PR, then other developers will constantly see these files change. Sadly, I can't find a set of arguments to helm package that produce the same .tgz file every time and the index has both a created and generated time stamp. Ideas?

Haha, sorry Ryan, didn't saw your message... I can move the create package process to a maven profile so it is created only with the profile.

@rjeberhard
Copy link
Member

I have an idea... I could get the latest modified time of any file under kubernetes/charts/weblogic-operator and compare that to the .tgz. Then, only helm package and repo index if there is a later source file.

@rjeberhard
Copy link
Member

Let me give that a try and then we'll fall back on the profile.

@jchermos
Copy link
Author

I have an idea... I could get the latest modified time of any file under kubernetes/charts/weblogic-operator and compare that to the .tgz. Then, only helm package and repo index if there is a later source file.

Pushed the changes you suggested with some changes.

@rjeberhard rjeberhard merged commit 37078be into develop Feb 14, 2019
@rjeberhard rjeberhard deleted the gh-pages-OWLS-69849 branch April 9, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants