Update Dockerfile to be in line with other WKT projects #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ddsharpe
previously approved these changes
Feb 15, 2023
ddsharpe
reviewed
Feb 15, 2023
Dockerfile
Outdated
| ENTRYPOINT ["sh", "start_exporter.sh"] | ||
| CMD ["/start_exporter.sh"] | ||
|
|
||
| EXPOSE 8080 |
Member
There was a problem hiding this comment.
Could use a newline at the end of the file.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Dockerfile now looks similar to the one for WKO and does not pull images from Docker Hub.
The only change in behavior is that the previous Dockerfile ran the Maven build in a stage while the updated Dockerfile expects that a Maven build has already been completed prior to creating the container image.
I've looked at a) the release automation here in this project, and b) the WKO integration tests that create a monitoring exporter image from scratch and both places already do the Maven build first.